Skip to content

[GTK3] Notify settings with "gtk-shell-shows-menubar" on menubar change#461

Merged
stackotter merged 1 commit intomoreSwift:mainfrom
gregcotten:fix-gtk3-menubar
Feb 25, 2026
Merged

[GTK3] Notify settings with "gtk-shell-shows-menubar" on menubar change#461
stackotter merged 1 commit intomoreSwift:mainfrom
gregcotten:fix-gtk3-menubar

Conversation

@gregcotten
Copy link
Contributor

This fixes a regression introduced by #325.

This change caused the GTK3 application menu bar to get set after the window is already shown, and apparently GTK doesn't like that.

This is apparently a #wontfix over on GNOME's gitlab:

I don't think application windows with menubars are common enough to fix this.

???

This is the only bandaid I could think of, and I'm not setup with a GTK4 environment to see if it's needed there.

@stackotter
Copy link
Collaborator

Thanks for investigating this! That seems like a suitable workaround to me. I’ll test on my own machine this morning and merge if all is well.

I don't think application windows with menubars are common enough to fix this.

Man, the Gtk devs really confuse me sometimes…

Copy link
Collaborator

@stackotter stackotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tested locally and it worked perfectly. Thanks for this!

@stackotter stackotter merged commit d54a5e9 into moreSwift:main Feb 25, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants